forked from nfl/react-gpt
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Andrew s/dev week #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable non-personalized Ads According to EU regulations, it is mandatory to enable users to opt-out to tracking cookies GPT allows us to respect this law using the `npa` flag on Ads. * Adding npa flag to re-render props * Fix npa variable in componentWillReceiveProps
Enable non-personalized Ads to support GDPR compliance
Fixes an issue where `setAttributes` can be called when there is no ad slot
Fix issue with Bling when there is no ad slot
Update package.json name and urls after forking
Update GPT API list to latest
Add prettier config and fix bracket spacing mismatch
Don't set state on an unmounted ad. Cribbed from axioscode@9425436.
Fix undefined function if apiNotReady. Cribbed from ticketmaster@5ef19b1.
Replace hasOwnProperty with more reliable check. Cribbed from nfl@8826ee3.
Fixes an issue where all ad slots would reload when syncCorrelator was true and a new slot was added
Check for deprecated updateCorrelator method before calling
* build: Update radium Update radium to fix "TypeError: Cannot read property 'object' of undefined" when running examples * Use ^
* fix: Stop multiple refresh on mq change Stops multiple calls to instance.refresh() on media query change. This can happen when an instance is associated with multiple instances. * Only debounce this.refresh * Fix comment
Adds the ability to specify a custom refresh function using `configure`. This function replaces the call to `pubads().refresh`. This is useful for certain header bidding configurations, such as App Nexus that requires to `pbjs.refresh` to be called.
Use googletag.cmd.push instead of timeout to check if pubads is ready. Fixes issue with recurring handler.
… url (#20) * Update all instances of googletagservices gpt url to securepubads gpt url * Add UNSAFE so we can look to update REACT * update remaining paths; use https to avoid redirect Co-authored-by: Andrew Berry <[email protected]>
* Remove deprecated ContentService usage * Update test * doc updates Co-authored-by: Andrew Sotiriou <[email protected]>
* Ton of MI updates * Minor changes
* Can work with negative viewability threshold. * Offset in log remark is now VT for clarity. * Checking for isNaN * removed logging Co-authored-by: Engywook2005 <[email protected]>
* Changed version and updated changelog * Fixed typo in package.json Co-authored-by: Engywook2005 <[email protected]>
* Fixes for neg VT * Update isHidden * Cleanup * Remove log * Update call
* update packageJSON version * Update changelog
This reverts commit 49fcf5b.
* update deps * update radium to version supporting react 17 * add prepare script * remove prepare script * findDOMNode is deprecated * make peerDependencies more lenient * ref needs to be on different node * Reverting the version as i will do that in another step --------- Co-authored-by: Andrew Sotiriou <[email protected]>
* Add stuff for lazy load * First shot at ignoring isInViewport response. * Will render ads even if the inviewport check fails * Removed commented out line of code * Version bump and changelog update --------- Co-authored-by: Andrew Sotiriou <[email protected]> Co-authored-by: Greg Thorson <[email protected]>
andrewb
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge in changes from nfl-reactgpt master
How can this change be manually tested?
...
Asana Card
https://app.asana.com/0/1198498632694766/1200448322596157/f
Questions or concerns about this change?
n/a
Deployment Notes
n/a
PR Readiness
Code Readiness
Automated Testing
Other Considerations
Also consider this PR's impact on architecture and security; AMP, Apple News, RSS; SEO, GA, performance and accessibility.
Please see Post Merge for additional responsibilities after this PR is merged.